C/C++ overlay: use files table instead of overlayChangedFiles for overlay discard
#21244
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdrissRio
changed the title
overlayChangedFiles for o…overlayChangedFiles for overlay discard
IdrissRio
added
depends on internal PR
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the C++ overlay discard logic to query extracted files directly from the files table in the overlay database, replacing the previous approach that relied on the overlayChangedFiles table populated by the CLI.
Changes:
- Introduced new
overlayHasFilepredicate that queries thefilestable to determine which files were extracted in the overlay database - Updated
discardElementpredicate to use the newoverlayHasFileapproach instead ofoverlayChangedFiles - Updated documentation comments to reflect that elements are discarded based on files extracted in the overlay rather than "changed files"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the C++ overlay discard logic to query extracted files directly from the overlay database instead of relying on
overlayChangedFilespopulated by the CLI.See internal PR.